1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/str.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, February 09, 2023 19:08:22
    https://gitlab.synchro.net/main/sbbs/-/commit/0975d578353111fc53f95127
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    Fix 30-year-old bug (obvious password patterns) in chkpass()

    Off-by-one bug caused the comparison of only the first 3 chars of the proposed password against "QWE", "ASD", and "!@#" rather than the 4 character pattern match as intended.

    These lines should be removed anyway since this can be easily achieved via password.can (as intended), but I couldn't help myself but to fix this ancient bug.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, October 25, 2023 19:26:24
    https://gitlab.synchro.net/main/sbbs/-/commit/e0d9cc8e28042df7cd86f647
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    Fix g++ compile error (did not appear with MSVC)

    error: ISO C++ forbids comparison between pointer and integer

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, February 02, 2024 00:26:28
    https://gitlab.synchro.net/main/sbbs/-/commit/76cda34346beea2052cee415
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    Fix sbbs_t::trashcan(), broken one month ago

    Transposed the order of parameters in commit 20dbd40c. Oops.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Monday, March 31, 2025 18:52:59
    https://gitlab.synchro.net/main/sbbs/-/commit/7be352ac1ab689194d27bec1
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    Support optional ctrl/<terminal-protocol>/text.ini file

    If the sysop wants custom text.dat strings to be unique per terminal
    connection protocol (e.g. telnet, rlogin, ssh, raw), this is how that
    can be achieved (e.g. ctrl/rlogin/text.ini can be used to override text.dat strings only for RLogin connections).

    To at least partially address issue #897

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, April 10, 2025 23:39:24
    https://gitlab.synchro.net/main/sbbs/-/commit/a81e64575c9f30c0a3af0fd5
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    Rework part of the "good password" checking algorithm

    Require that a good password contain a sequence of unique characters
    (not repeating, incrementing, or decrementing in ASCII code value) of at least half the configured minimum password length. By default, the minimum password length is 4 chars, so this means a sequence of at least 2 unique characters
    is required. If the minimum password length is increased by the sysop, so is the minimum required unique sequence length. The "PasswordInvalid" text.dat string is printed when passwords are rejected by this criteria.

    Previously, the following would be rejected by this portion of the algo,
    this logic has been replaced by the above:
    - all chars the same (would print the "PasswordInvalid" text.dat string)
    - first 4 chars are incrementing ("PasswordObvious" string printed)
    - first 4 chars are decrementing ("PasswordObvious" string printed)

    but now, a password that starts with "1234" or "abcd" is fine so long as it's longer than that and contains the minimum unique sequence length. This will prevent SBBS from rejecting high quality (e.g. randomly generated or crypto-hashed) passwords that just happen to begin with an incrementing sequence of 4 digits or alpha-characters.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, May 20, 2025 20:29:15
    https://gitlab.synchro.net/main/sbbs/-/commit/6e91b37768cb527efc9cd9d7
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    Handle getuserdat() failure in sbbs_t::change_user()

    Address Coverity CID 551209

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, January 03, 2026 00:14:09
    https://gitlab.synchro.net/main/sbbs/-/commit/9e3ca95d9c966929f720d453
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    Overhaul the gettmplt() (in JS, console.gettemplate) function

    Oh this was (and in some ways is still) oh so broken and has been forever.

    If backspace, DEL, or Ctrl-X was used, the returned string was often not what was being displayed on the terminal when the user hit ENTER. <sigh>

    - Ctrl-X, Backspace and DEL actually clear out the entered text now
    Backspace/DEL don't remove the non-template (e.g. symbol) chars though
    - The left and right arrows keys can now be used to traverse the edited text
    - TAB is now treated the same as CR (much like getstr())
    - When editing a string, the cursor starts at the first character instead of
    the last as this seems much more convenient. Perhaps getstr() should get the
    treatment, but I hesitate because getstr() is used by so many.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, January 09, 2026 02:24:03
    https://gitlab.synchro.net/main/sbbs/-/commit/808412db3363f14dd56a7a58
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    If the file text/menu/[sub|dir]info.* exists, display it

    ... instead of SubInfo or DirInfo text strings.

    Another couple optional displays file that can be used to replace built-in logic and text strings for easier customization.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, January 12, 2026 00:51:06
    https://gitlab.synchro.net/main/sbbs/-/commit/0953bd8f6d476074c2d5418e
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    A blank line before the View system information file? prompt looks better

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, February 12, 2026 20:24:34
    https://gitlab.synchro.net/main/sbbs/-/commit/f6a94c9e0a470a83acda5329
    Modified Files:
    src/sbbs3/str.cpp
    Log Message:
    replace_text() now supports the text[.*].ini [substr] section

    This allows substring replacements in text.<lang>.ini files, for example, making localization (translations to non-English languages) even more practical.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net