• src/sbbs3/sbbs.h

    From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Monday, June 26, 2023 12:23:25
    https://gitlab.synchro.net/main/sbbs/-/commit/461682fbbc3196ae2a2d5fc3
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Thread-safe wrappers for std/socket errno description getters for sbbs_t

    These should only be used in the sbbs_t methods called by node_thread or event_thread. Any other thread-shared sbbs_t instances should not use these methods since they share a single error description string buffer.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, October 25, 2023 21:19:54
    https://gitlab.synchro.net/main/sbbs/-/commit/492a8506b3389c25d8d80823
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Need explicit include of string header here for G++, wasn't needed for MSVC

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, October 26, 2023 01:16:20
    https://gitlab.synchro.net/main/sbbs/-/commit/329f740f9eb51f7d598454d6
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Don't try to include modern C++ headers when building C++ Builder

    C++ Builder6 doesn't have unordered_map, so only #include those std C++
    headers if/where we actually need them.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, November 22, 2023 15:30:20
    https://gitlab.synchro.net/main/sbbs/-/commit/6025299141fa32141265201b
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Fix CID 469129 and 469141 using std::atomic<>

    Unlikely, but valid thread-safety concerns by Coverity

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, November 22, 2023 15:53:05
    https://gitlab.synchro.net/main/sbbs/-/commit/e0cef49cc0c560a43da814b3
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Fix gcc/clang build error

    std::atomic's need to be brace-initialized, or else we fail with
    "use of deleted function" errors

    Odd that MSVC built it just fine.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thursday, February 15, 2024 23:02:56
    https://gitlab.synchro.net/main/sbbs/-/commit/174875d641601dd475b00280
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Use the do/while(0) trick to eliminate warnings w/use of SAEFCOPY_UTF8

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, February 20, 2024 16:35:40
    https://gitlab.synchro.net/main/sbbs/-/commit/1791c0b26db64308633520bb
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Unhack mingw32 hack for mingw32-w64

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, February 27, 2024 14:43:25
    https://gitlab.synchro.net/main/sbbs/-/commit/7e505d6f3e00a839a4937f35
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Name structs to attempt to silence warnings from GCC.

    It seems that GCC is concerned that we can't create a sftp_dirdescriptor_t
    or sftp_filedescriptor_t?

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, December 30, 2025 16:39:35
    https://gitlab.synchro.net/main/sbbs/-/commit/4a2c2c708c57d0aa2d3a69d3
    Modified Files:
    src/sbbs3/sbbs.h
    Log Message:
    Make sbbs_t::online and sys_static atomic member variables

    Since sbbs_t::online and sys_status are modified and checked in different threads, they really should've been atomic or at least volatile to prevent
    the compiler-optimizer from using the current/updated values at all times.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to Rob Swindell (on Windows 11) on Tuesday, December 30, 2025 16:49:39
    Re: src/sbbs3/sbbs.h
    By: Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Tue Dec 30 2025 04:39 pm

    Since sbbs_t::online and sys_status are modified and checked in different threads, they really should've been atomic or at least volatile to prevent the compiler-optimizer from using the current/updated values at all times.

    that should read: prevent the compiler-optimizer from *not* using ...
    --
    digital man (rob)

    Steven Wright quote #25:
    If at first you don't succeed, destroy all evidence that you tried.
    Norco, CA WX: 66.8øF, 27.0% humidity, 7 mph ESE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net